hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7495) Remove updatePosition argument from DFSInputStream#getBlockAt()
Date Tue, 24 Feb 2015 06:09:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334465#comment-14334465

Hadoop QA commented on HDFS-7495:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision 5857686.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:


Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9651//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9651//console

This message is automatically generated.

> Remove updatePosition argument from DFSInputStream#getBlockAt()
> ---------------------------------------------------------------
>                 Key: HDFS-7495
>                 URL: https://issues.apache.org/jira/browse/HDFS-7495
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Ted Yu
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-7495.002.patch, hdfs-7495-001.patch
> There're two locks: one on DFSInputStream.this , one on DFSInputStream.infoLock
> Normally lock is obtained on infoLock, then on DFSInputStream.infoLock
> However, such order is not observed in DFSInputStream#getBlockAt() :
> {code}
>     synchronized(infoLock) {
> ...
>       if (updatePosition) {
>         // synchronized not strictly needed, since we only get here
>         // from synchronized caller methods
>         synchronized(this) {
> {code}

This message was sent by Atlassian JIRA

View raw message