hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7411) Refactor and improve decommissioning logic into DecommissionManager
Date Thu, 05 Feb 2015 00:03:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306261#comment-14306261
] 

Tsz Wo Nicholas Sze commented on HDFS-7411:
-------------------------------------------

I do not intention to block the decommission improvement.  However, it is really a bad idea
to arbitrarily change the behavior of a public conf when keeping the existing behavior is
easy, and mixing code refactoring with improvement in a big patch.

[~andrew.wang], I am glad that you split the slf4j change from here to HDFS-7706 and filed
another minor JIRA HDFS-7712 for the further work.  If the work is included here, the blocker
JIRA HDFS-7734 will be broken by the unnecessarily complicated patch here.

In order to move faster, how about I volunteer doing the refactoring?

> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
>                 Key: HDFS-7411
>                 URL: https://issues.apache.org/jira/browse/HDFS-7411
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.5.1
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch, hdfs-7411.003.patch, hdfs-7411.004.patch,
hdfs-7411.005.patch, hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch, hdfs-7411.009.patch,
hdfs-7411.010.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to DecommissionManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message