Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 26 Jan 2015 19:23:34 +0000 (UTC)
From: "Colin Patrick McCabe (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12769690.1422035128000.175216.1422300214862@Atlassian.JIRA>
In-Reply-To: <JIRA.12769690.1422035128000@Atlassian.JIRA>
References: <JIRA.12769690.1422035128000@Atlassian.JIRA>
 <JIRA.12769690.1422035128719@arcas>
Subject: [jira] [Commented] (HDFS-7666) Datanode blockId layout upgrade
 threads should be daemon thread
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292273#comment-14292273 ] 

Colin Patrick McCabe commented on HDFS-7666:
--------------------------------------------

Hi Rakesh,

I'm not sure why we would want the blockID upgrade threads to be daemon threads.  Daemon threads don't block the JVM from exiting if they are the only remaining threads.  But we don't expect the JVM to while an upgrade is still incomplete.  In fact, if it does, we are in big trouble.

> Datanode blockId layout upgrade threads should be daemon thread
> ---------------------------------------------------------------
>
>                 Key: HDFS-7666
>                 URL: https://issues.apache.org/jira/browse/HDFS-7666
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-7666-v1.patch
>
>
> This jira is to mark the layout upgrade thread as daemon thread.
> {code}
>      int numLinkWorkers = datanode.getConf().getInt(
>          DFSConfigKeys.DFS_DATANODE_BLOCK_ID_LAYOUT_UPGRADE_THREADS_KEY,
>          DFSConfigKeys.DFS_DATANODE_BLOCK_ID_LAYOUT_UPGRADE_THREADS);
>     ExecutorService linkWorkers = Executors.newFixedThreadPool(numLinkWorkers);
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)