Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6672710AA6 for ; Tue, 20 Jan 2015 15:10:40 +0000 (UTC) Received: (qmail 24988 invoked by uid 500); 20 Jan 2015 15:10:39 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24927 invoked by uid 500); 20 Jan 2015 15:10:39 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 24798 invoked by uid 99); 20 Jan 2015 15:10:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2015 15:10:39 +0000 Date: Tue, 20 Jan 2015 15:10:39 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7638) Small fix and few refinements for FSN#truncate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283902#comment-14283902 ] Hudson commented on HDFS-7638: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #80 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/80/]) HDFS-7638: Small fix and few refinements for FSN#truncate. (yliu) (yliu: rev 5a6c084f074990a1f412475b147fd4f040b57d57) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Small fix and few refinements for FSN#truncate > ---------------------------------------------- > > Key: HDFS-7638 > URL: https://issues.apache.org/jira/browse/HDFS-7638 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Reporter: Yi Liu > Assignee: Yi Liu > Fix For: 3.0.0 > > Attachments: HDFS-7638.001.patch > > > *1.* > {code} > removeBlocks(collectedBlocks); > {code} > should be after {{logSync}}, as we do in other FSN places (rename, delete, write with overwrite), the reason is discussed in HDFS-2815 and https://issues.apache.org/jira/browse/HDFS-6871?focusedCommentId=14110068&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14110068 > *2.* > {code} > stat = FSDirStatAndListingOp.getFileInfo(dir, src, false, > FSDirectory.isReservedRawName(src), true); > {code} > We'd better to use {{dir.getAuditFileInfo}}, since it's only for audit log. If audit log is not on, we don't need to get the file info. > *3.* > In {{truncateInternal}}, > {code} > INodeFile file = iip.getLastINode().asFile(); > {code} > is not necessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)