hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7666) Datanode blockId layout upgrade threads should be daemon thread
Date Mon, 26 Jan 2015 19:23:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292273#comment-14292273
] 

Colin Patrick McCabe commented on HDFS-7666:
--------------------------------------------

Hi Rakesh,

I'm not sure why we would want the blockID upgrade threads to be daemon threads.  Daemon threads
don't block the JVM from exiting if they are the only remaining threads.  But we don't expect
the JVM to while an upgrade is still incomplete.  In fact, if it does, we are in big trouble.

> Datanode blockId layout upgrade threads should be daemon thread
> ---------------------------------------------------------------
>
>                 Key: HDFS-7666
>                 URL: https://issues.apache.org/jira/browse/HDFS-7666
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-7666-v1.patch
>
>
> This jira is to mark the layout upgrade thread as daemon thread.
> {code}
>      int numLinkWorkers = datanode.getConf().getInt(
>          DFSConfigKeys.DFS_DATANODE_BLOCK_ID_LAYOUT_UPGRADE_THREADS_KEY,
>          DFSConfigKeys.DFS_DATANODE_BLOCK_ID_LAYOUT_UPGRADE_THREADS);
>     ExecutorService linkWorkers = Executors.newFixedThreadPool(numLinkWorkers);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message