hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7647) DatanodeManager.sortLocatedBlocks() sorts DatanodeInfos but not StorageIDs
Date Wed, 21 Jan 2015 23:48:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286567#comment-14286567
] 

Arpit Agarwal commented on HDFS-7647:
-------------------------------------

Hi Milan, while this solution would work I'd prefer the other approach you suggested. We should
fix LocatedBlock to group the three fields in a new class. Existing code (except sortLocatedBlocks)
can be shielded from the change by keeping public the interface the same. What do you think?

> DatanodeManager.sortLocatedBlocks() sorts DatanodeInfos but not StorageIDs
> --------------------------------------------------------------------------
>
>                 Key: HDFS-7647
>                 URL: https://issues.apache.org/jira/browse/HDFS-7647
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Milan Desai
>            Assignee: Milan Desai
>         Attachments: HDFS-7647.patch
>
>
> DatanodeManager.sortLocatedBlocks() sorts the array of DatanodeInfos inside each LocatedBlock,
but does not touch the array of StorageIDs and StorageTypes. As a result, the DatanodeInfos
and StorageIDs/StorageTypes are mismatched. The method is called by FSNamesystem.getBlockLocations(),
so the client will not know which StorageID/Type corresponds to which DatanodeInfo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message