hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7637) Fix the check condition for reserved path
Date Mon, 19 Jan 2015 11:38:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282423#comment-14282423
] 

Hadoop QA commented on HDFS-7637:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12693029/HDFS-7637.001.patch
  against trunk revision 19cbce3.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9263//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9263//console

This message is automatically generated.

> Fix the check condition for reserved path
> -----------------------------------------
>
>                 Key: HDFS-7637
>                 URL: https://issues.apache.org/jira/browse/HDFS-7637
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>            Priority: Minor
>         Attachments: HDFS-7637.001.patch
>
>
> Currently the {{.reserved}} patch check function is:
> {code}
> public static boolean isReservedName(String src) {
>   return src.startsWith(DOT_RESERVED_PATH_PREFIX);
> }
> {code}
> And {{DOT_RESERVED_PATH_PREFIX}} is {{/.reserved}}, it should be {{/.reserved/}}, for
example: if some other directory prefix with _/.reserved_, we say it's _/.reservedpath_, then
the check is wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message