hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7606) Missing null check in INodeFile#getBlocks()
Date Thu, 15 Jan 2015 19:58:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279215#comment-14279215
] 

Konstantin Shvachko commented on HDFS-7606:
-------------------------------------------

Hey Chen, what is the point of a unit test if it doesn't correspond to a real life scenario?

> Missing null check in INodeFile#getBlocks()
> -------------------------------------------
>
>                 Key: HDFS-7606
>                 URL: https://issues.apache.org/jira/browse/HDFS-7606
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ted Yu
>            Assignee: Byron Wong
>            Priority: Minor
>         Attachments: HDFS-7606-1.patch, HDFS-7606.patch
>
>
> {code}
>     BlockInfo[] snapshotBlocks = diff == null ? getBlocks() : diff.getBlocks();
>     if(snapshotBlocks != null)
>       return snapshotBlocks;
>     // Blocks are not in the current snapshot
>     // Find next snapshot with blocks present or return current file blocks
>     snapshotBlocks = getDiffs().findLaterSnapshotBlocks(diff.getSnapshotId());
> {code}
> If diff is null and snapshotBlocks is null, NullPointerException would result from the
call to diff.getSnapshotId().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message