hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7583) Fix findbug in TransferFsImage.java
Date Mon, 05 Jan 2015 13:03:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264562#comment-14264562
] 

Hadoop QA commented on HDFS-7583:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12690055/HDFS-7583-001.patch
  against trunk revision 21c6f01.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9141//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9141//console

This message is automatically generated.

> Fix findbug in TransferFsImage.java
> -----------------------------------
>
>                 Key: HDFS-7583
>                 URL: https://issues.apache.org/jira/browse/HDFS-7583
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>            Priority: Minor
>         Attachments: HDFS-7583-001.patch
>
>
> Fix following findbug resulting in recent jenkins runs
> {noformat}Exceptional return value of java.io.File.delete() ignored in org.apache.hadoop.hdfs.server.namenode.TransferFsImage.deleteTmpFiles(List)
> Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details) 
> In class org.apache.hadoop.hdfs.server.namenode.TransferFsImage
> In method org.apache.hadoop.hdfs.server.namenode.TransferFsImage.deleteTmpFiles(List)
> Called method java.io.File.delete()
> At TransferFsImage.java:[line 577]{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message