hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7496) Fix FsVolume removal race conditions on the DataNode
Date Wed, 14 Jan 2015 23:02:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277851#comment-14277851
] 

Colin Patrick McCabe commented on HDFS-7496:
--------------------------------------------

Thanks, [~eddyxu].  This looks very good.

My only comment is that {{ReplicaInPipelineWithVolumeReference}} is a long name.  What if
it were called {{ReplicaHandle}} or something?  Also, if this object implemented {{Closeable}},
this might help us avoid leaks.  Then in the {{BlockReceiver}}, we could hold on to the {{ReplicaHandle}}
and call {{ReplicaHandle#close}} when necessary.

+1 once that's addressed

> Fix FsVolume removal race conditions on the DataNode 
> -----------------------------------------------------
>
>                 Key: HDFS-7496
>                 URL: https://issues.apache.org/jira/browse/HDFS-7496
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-7496.000.patch, HDFS-7496.001.patch, HDFS-7496.002.patch, HDFS-7496.003.patch,
HDFS-7496.003.patch, HDFS-7496.004.patch
>
>
> We discussed a few FsVolume removal race conditions on the DataNode in HDFS-7489.  We
should figure out a way to make removing an FsVolume safe.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message