hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7353) Raw Erasure Coder API for concrete encoding and decoding
Date Mon, 26 Jan 2015 23:04:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292580#comment-14292580
] 

Zhe Zhang commented on HDFS-7353:
---------------------------------

Good work [~drankye]! Please find my comments below:
# {{ECChunk}} looks good to me. It's helpful to handle both array and {{ByteBuffer}}
# {{RawErasureCoder}}:
#* Please make sure no line is longer than 80 chars
#* {{dataSize}}, {{paritySize}}, and {{chunkSize}} apply to all descendants of this interface.
Shouldn't they become member variables?
#* {{dataSize}} and {{paritySize}} could be better named because _size_ could mean number
of bytes too. How about {{numDataBlks}} and {{numParityBlks}}?
#* What potential implementation of the interface could need {{release()}}? Better mention
it in the comment.
# {{RawErasureEncoder}} and {{RawErasureDecoder}}
#* Since {{ECChunk}} already wraps around byte arrays and {{ByteBuffer}}, do we still need
3 versions of {{encode}} and {{decode}}?
# {{AbstractRawErasureCoder}}
#* Shouldn't {{toBuffers}} and {{toArray}} be static methods in the {{ECChunk}} class?

All above should be easy to address. +1 pending these updates.


> Raw Erasure Coder API for concrete encoding and decoding
> --------------------------------------------------------
>
>                 Key: HDFS-7353
>                 URL: https://issues.apache.org/jira/browse/HDFS-7353
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>             Fix For: HDFS-EC
>
>         Attachments: HDFS-7353-v1.patch, HDFS-7353-v2.patch, HDFS-7353-v3.patch, HDFS-7353-v4.patch
>
>
> This is to abstract and define raw erasure coder API across different codes algorithms
like RS, XOR and etc. Such API can be implemented by utilizing various library support, such
as Intel ISA library and Jerasure library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message