hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7323) Move the get/setStoragePolicy commands out from dfsadmin
Date Fri, 09 Jan 2015 02:47:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270455#comment-14270455
] 

Yi Liu commented on HDFS-7323:
------------------------------

Thanks Jing. 
The patch looks good to me, just few comments, +1 after addressing and pending Jenkins.
*1.*
{code}
return "[" + getName() + "-path <path>]\n";
return "[" + getName() + "-path <path> -policy <policy>]";
{code}
We should have a space before *-path*
*2.*
In {{StoragePolicyAdmin}} and other class under {{org.apache.hadoop.hdfs.tools}}, such as
{{CacheAdmin}}, {{CryptoAdmin}}. There are too many common methods ({{getDFS}}, {{prettifyException}},
{{getOptionDescriptionListing}} ...) and also inner class ({{HelpCommand}}), they are the
same, it would be great if you can refine and shift them into a common place. Of course this
comment it's nice to have, it will not block the commit.

> Move the get/setStoragePolicy commands out from dfsadmin
> --------------------------------------------------------
>
>                 Key: HDFS-7323
>                 URL: https://issues.apache.org/jira/browse/HDFS-7323
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Jing Zhao
>         Attachments: HDFS-7323.000.patch, HDFS-7323.001.nocmd.patch, HDFS-7323.001.patch
>
>
> After HDFS-7093, setting storage policy no longer requires superuser privilege.  We should
move the get/setStoragePolicy commands out from dfsadmin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message