hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhanwei Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7018) Implement C interface for libhdfs3
Date Wed, 28 Jan 2015 01:55:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294583#comment-14294583

Zhanwei Wang commented on HDFS-7018:

Hi [~cmccabe]

About using the exception in C\+\+, Google also list many benefits and give a conclusion {{the
benefits of using exceptions outweigh the costs, especially in new projects}}.

Anyway, it's a controversial topic and not related to this JIRA. We can discuss this issue
in another JIRA and make this JIRA clear.

bq. Do we need to change the type of blocksize here? That is going to potentially impact libhdfs
and libwebhdfs

{{blocksize}} is 64bit integer in JAVA code and JAVA API. I cannot find any reason to restrict
it to 32bit in C API. 
About the impact:
1) This API change is compatible, so existing application do not need to change. 
2) The libhdfs code do not need to change, it use {{jlong}} which is 64bit.
3) The libwebhdfs code is more complicated. It use {{tSize}} and {{size_t}} internally in
different place to hold block size.
So libwebhdfs needs more code change if we change blocksize to 64bit. 

I'm not sure if it is good to make such API change in this JIRA. What's your opinion?

> Implement C interface for libhdfs3
> ----------------------------------
>                 Key: HDFS-7018
>                 URL: https://issues.apache.org/jira/browse/HDFS-7018
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Zhanwei Wang
>            Assignee: Zhanwei Wang
>         Attachments: HDFS-7018-pnative.002.patch, HDFS-7018-pnative.003.patch, HDFS-7018-pnative.004.patch,
> Implement C interface for libhdfs3

This message was sent by Atlassian JIRA

View raw message