hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-49) MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found
Date Tue, 27 Jan 2015 14:31:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293604#comment-14293604
] 

Hudson commented on HDFS-49:
----------------------------

SUCCESS: Integrated in Hadoop-Hdfs-trunk #2018 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2018/])
HDFS-49. MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching
name is not found. (stevel) (stevel: rev 0da53a37ec46b887f441df98c6986b31fa7671a2)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java


> MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching
name is not found
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-49
>                 URL: https://issues.apache.org/jira/browse/HDFS-49
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.1.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>              Labels: codereview, newbie
>             Fix For: 2.7.0
>
>         Attachments: HDFS-49-002.patch, hdfs-49.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The stopDataNode method will shut down the last node in the list of nodes, if one matching
a specific name is not found
> This is possibly not what was intended. Better to return false or fail in some other
manner if the named node was not located
>  synchronized boolean stopDataNode(String name) {
>     int i;
>     for (i = 0; i < dataNodes.size(); i++) {
>       DataNode dn = dataNodes.get(i).datanode;
>       if (dn.dnRegistration.getName().equals(name)) {
>         break;
>       }
>     }
>     return stopDataNode(i);
>   }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message