Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 725AE9C5D for ; Wed, 24 Dec 2014 00:17:14 +0000 (UTC) Received: (qmail 3082 invoked by uid 500); 24 Dec 2014 00:17:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 3022 invoked by uid 500); 24 Dec 2014 00:17:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 3010 invoked by uid 99); 24 Dec 2014 00:17:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Dec 2014 00:17:13 +0000 Date: Wed, 24 Dec 2014 00:17:13 +0000 (UTC) From: "Haohui Mai (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HDFS-7567) Potential null dereference in FSEditLogLoader#applyEditLogOp() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai resolved HDFS-7567. ------------------------------ Resolution: Invalid I don't think it can happen after taking both branches into consideration. > Potential null dereference in FSEditLogLoader#applyEditLogOp() > -------------------------------------------------------------- > > Key: HDFS-7567 > URL: https://issues.apache.org/jira/browse/HDFS-7567 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > > {code} > INodeFile oldFile = INodeFile.valueOf(iip.getLastINode(), path, true); > if (oldFile != null && addCloseOp.overwrite) { > ... > INodeFile newFile = oldFile; > ... > // Update the salient file attributes. > newFile.setAccessTime(addCloseOp.atime, Snapshot.CURRENT_STATE_ID); > newFile.setModificationTime(addCloseOp.mtime, Snapshot.CURRENT_STATE_ID); > {code} > The last two lines are not protected by null check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)