Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 161731083E for ; Tue, 9 Dec 2014 19:26:13 +0000 (UTC) Received: (qmail 10671 invoked by uid 500); 9 Dec 2014 19:26:12 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 10613 invoked by uid 500); 9 Dec 2014 19:26:12 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 10601 invoked by uid 99); 9 Dec 2014 19:26:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Dec 2014 19:26:12 +0000 Date: Tue, 9 Dec 2014 19:26:12 +0000 (UTC) From: "Jing Zhao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7498) Simplify the logic in INodesInPath MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239896#comment-14239896 ] Jing Zhao commented on HDFS-7498: --------------------------------- Thanks for the review, Haohui! bq. Is it accidental? No. After we have INode feature we no longer have inode replacement logic. Thus we do not need to reset the parent node in the INodesInPath here. > Simplify the logic in INodesInPath > ---------------------------------- > > Key: HDFS-7498 > URL: https://issues.apache.org/jira/browse/HDFS-7498 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-7498.000.patch > > > Currently we have relatively complicated logic in INodesInPath: > 1) It can contain null elements in its INode array, and in {{mkdirRecursively}} these null INodes are replaced with new directories. > 2) Operations like rename may also replace the inode in its INode array > 3) {{getINodes}} requires trimming inodes array if the INodesInPath is derived from a dot-snapshot path > 4) A lot of methods directly use/manipulate its INode array > We aim to simplify the logic of INodesInPath in this jira. Specifically, we can > make INodesInPath an immutable data structure and move the inode trimming logic to path resolving. -- This message was sent by Atlassian JIRA (v6.3.4#6332)