Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 263A810772 for ; Tue, 2 Dec 2014 12:42:13 +0000 (UTC) Received: (qmail 94646 invoked by uid 500); 2 Dec 2014 12:42:12 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 94598 invoked by uid 500); 2 Dec 2014 12:42:12 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 94587 invoked by uid 99); 2 Dec 2014 12:42:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Dec 2014 12:42:12 +0000 Date: Tue, 2 Dec 2014 12:42:12 +0000 (UTC) From: "Tsz Wo Nicholas Sze (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-7457) DatanodeID generates excessive garbage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated HDFS-7457: -------------------------------------- Hadoop Flags: Reviewed +1 patch looks good. > DatanodeID generates excessive garbage > -------------------------------------- > > Key: HDFS-7457 > URL: https://issues.apache.org/jira/browse/HDFS-7457 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.0.0-alpha, 3.0.0 > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Attachments: HDFS-7457.patch > > > {{DatanodeID#getXferAddr}} is a dynamically generated string. This string is repeatedly generated for the hash code, equality, comparisons, and stringification. Every DN->NN RPC method calls {{DatanodeManager#getDatanode}} to validate if the node is registered, which involves a call to {{getXferAddr}}. > The dynamic computation generates unnecessary trash that puts unnecessary pressure on the GC. -- This message was sent by Atlassian JIRA (v6.3.4#6332)