Return-Path: 
 <hdfs-issues-return-103255-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D18DDC840
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Tue,  2 Dec 2014 05:31:13 +0000 (UTC)
Received: (qmail 99673 invoked by uid 500); 2 Dec 2014 05:31:13 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 99615 invoked by uid 500); 2 Dec 2014 05:31:12 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 99602 invoked by uid 99); 2 Dec 2014 05:31:12 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Dec 2014 05:31:12 +0000
Date: Tue, 2 Dec 2014 05:31:12 +0000 (UTC)
From: "Kai Zheng (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12752687.1415103480000.55465.1417498272842@Atlassian.JIRA>
In-Reply-To: <JIRA.12752687.1415103480000@Atlassian.JIRA>
References: <JIRA.12752687.1415103480000@Atlassian.JIRA>
 <JIRA.12752687.1415103480163@arcas>
Subject: [jira] [Commented] (HDFS-7349) Support DFS command for the EC
 encoding
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HDFS-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231023#comment-14231023 ] 

Kai Zheng commented on HDFS-7349:
---------------------------------

Hi Vinay,

The patch looks great even in the initial stage. My comments are:
1. Looks like more tasks are done than said in the issue description. Should we change it to reflect that?
2. Regarding the new command usage: 
* convertToEC may need a schema parameter; 
* help and usage may be redundant;
* could we use "ec" instead of "erasure" for the command? Single word 'erasure' might not be complete to mean 'erasure coding'.
* what does async mean? In my understanding the two operations could/should always be done in async manner as they're very time consuming.

3. We would have a default EC schema that's built in the system but can be overridden by via configuration for user's convenience. When convertToEC with no schema given, the default schema will be employed. Makes sense?
4. Minor, in ClientNamenodeProtocolServerSideTranslatorPB.java, looks like too many import lines are affected.
5. Minor, to be consistent among us using EC as the common prefix, could we rename some constructs like ErasureCli like to be ECCli? Thanks.
6. Should we upgrade any RPC version for the protocol extension?

Please help clarify if I misunderstood any point. Thanks.

> Support DFS command for the EC encoding
> ---------------------------------------
>
>                 Key: HDFS-7349
>                 URL: https://issues.apache.org/jira/browse/HDFS-7349
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-7349-001.patch
>
>
> Support implementation of the following commands
> *hdfs dfs -convertToEC <path>*
>    <path>: Converts all blocks under this path to EC form (if not already in EC form, and if can be coded).
> *hdfs dfs -convertToRep <path>*
>    <path>: Converts all blocks under this path to be replicated form.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)