hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7567) Potential null dereference in FSEditLogLoader#applyEditLogOp()
Date Wed, 24 Dec 2014 04:31:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257945#comment-14257945
] 

Hadoop QA commented on HDFS-7567:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12688959/hdfs-7567.patch
  against trunk revision 66cfe1d.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.util.TestByteArrayManager

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9120//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9120//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9120//console

This message is automatically generated.

> Potential null dereference in FSEditLogLoader#applyEditLogOp()
> --------------------------------------------------------------
>
>                 Key: HDFS-7567
>                 URL: https://issues.apache.org/jira/browse/HDFS-7567
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: hdfs-7567.patch
>
>
> {code}
>       INodeFile oldFile = INodeFile.valueOf(iip.getLastINode(), path, true);
>       if (oldFile != null && addCloseOp.overwrite) {
> ...
>       INodeFile newFile = oldFile;
> ...
>       // Update the salient file attributes.
>       newFile.setAccessTime(addCloseOp.atime, Snapshot.CURRENT_STATE_ID);
>       newFile.setModificationTime(addCloseOp.mtime, Snapshot.CURRENT_STATE_ID);
> {code}
> The last two lines are not protected by null check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message