hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7551) Fix the new findbugs warning from TransferFsImage
Date Fri, 19 Dec 2014 06:23:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253029#comment-14253029
] 

Hadoop QA commented on HDFS-7551:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12688221/HDFS-7551-001.txt
  against trunk revision efe6357.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.fs.TestSymlinkHdfsFileContext
                  org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
                  org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9088//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9088//console

This message is automatically generated.

> Fix the new findbugs warning from TransferFsImage
> -------------------------------------------------
>
>                 Key: HDFS-7551
>                 URL: https://issues.apache.org/jira/browse/HDFS-7551
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>         Attachments: HDFS-7551-001.txt, HDFS-7551-002.txt
>
>
> There is a findbug warning in https://builds.apache.org/job/PreCommit-HDFS-Build/9080//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
, 
> {code}
> Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE
> In class org.apache.hadoop.hdfs.server.namenode.TransferFsImage
> In method org.apache.hadoop.hdfs.server.namenode.TransferFsImage.deleteTmpFiles(List)
> Called method java.io.File.delete()
> At TransferFsImage.java:[line 577]
> {code}
> seems to me it came from https://issues.apache.org/jira/browse/HDFS-7373 's change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message