hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Lamb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7529) Consolidate encryption zone related implementation into a single class
Date Thu, 18 Dec 2014 00:04:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250848#comment-14250848
] 

Charles Lamb commented on HDFS-7529:
------------------------------------

Hi @wheat9,

While the .001 patch fixes the formatting issues, the larger problem is that by calling provider.getMetadata()
inside the lock, you're doing an RPC (inside the lock). While it is true that you may have
been able to contact the KMS during ensureKeysAreInitialized, that may not be true when you
try later and there can be an arbitrarily long delay. BTW, there's a plurality mismatch between
ensureKeysAreInitialized (plural) and the method it calls (generateEncryptedDataEncryptionKey,
which is singular).

Charles


> Consolidate encryption zone related implementation into a single class
> ----------------------------------------------------------------------
>
>                 Key: HDFS-7529
>                 URL: https://issues.apache.org/jira/browse/HDFS-7529
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-7529.000.patch, HDFS-7529.001.patch
>
>
> This jira proposes to consolidate encryption zone related implementation to a single
class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message