hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7494) Checking of closed in DFSInputStream#pread() should be protected by synchronization
Date Sat, 13 Dec 2014 03:01:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245139#comment-14245139
] 

Hadoop QA commented on HDFS-7494:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12686991/hdfs-7494-002.patch
  against trunk revision fa7b924.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in hadoop-hdfs-project/hadoop-hdfs


Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9034//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9034//console

This message is automatically generated.

> Checking of closed in DFSInputStream#pread() should be protected by synchronization
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-7494
>                 URL: https://issues.apache.org/jira/browse/HDFS-7494
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: hdfs-7494-001.patch, hdfs-7494-002.patch
>
>
> {code}
>   private int pread(long position, byte[] buffer, int offset, int length)
>       throws IOException {
>     // sanity checks
>     dfsClient.checkOpen();
>     if (closed) {
> {code}
> Checking of closed should be protected by holding lock on "DFSInputStream.this"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message