hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7475) Make TestLazyPersistFiles#testLazyPersistBlocksAreSaved deterministic
Date Wed, 10 Dec 2014 21:14:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241742#comment-14241742
] 

Hadoop QA commented on HDFS-7475:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12686323/HDFS-7475.1.patch
  against trunk revision 2e98ad3.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 40 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

                                      The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.TestGetBlocks

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8993//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8993//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8993//console

This message is automatically generated.

> Make TestLazyPersistFiles#testLazyPersistBlocksAreSaved deterministic 
> ----------------------------------------------------------------------
>
>                 Key: HDFS-7475
>                 URL: https://issues.apache.org/jira/browse/HDFS-7475
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.6.0
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HDFS-7475.0.patch, HDFS-7475.1.patch
>
>
> TestLazyPersistFiles#testLazyPersistBlocksAreSaved verifies that the memory block is
saved in lazy persist directory after some sleep with the following code. 
> {code}
>     // Sleep for a short time to allow the lazy writer thread to do its job
>     Thread.sleep(6 * LAZY_WRITER_INTERVAL_SEC * 1000);
> {code} 
> However, the sleep only guarantees an async lazy persist task is scheduled. The task
running on a per volume thread pool thread can take longer to finish persisting. It will be
more deterministic to wait the pending lazy persist task count reduce to 0 before verifying
the block file exist in lazy persist dir. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message