hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7473) Setting dfs.namenode.fs-limits.max-directory-items to 0 in hdfs-site.xml leads to error
Date Fri, 05 Dec 2014 06:16:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235153#comment-14235153
] 

Akira AJISAKA commented on HDFS-7473:
-------------------------------------

Thanks for the report, [~keller-jason].
After HDFS-6102, setting the property to 0 is invalid. We should update the error message
{code}
    Preconditions.checkArgument(
        maxDirItems > 0 && maxDirItems <= MAX_DIR_ITEMS, "Cannot set "
            + DFSConfigKeys.DFS_NAMENODE_MAX_DIRECTORY_ITEMS_KEY
            + " to a value less than 0 or greater than " + MAX_DIR_ITEMS);
{code}
to 
{code}
    Preconditions.checkArgument(
        maxDirItems > 0 && maxDirItems <= MAX_DIR_ITEMS, "Cannot set "
            + DFSConfigKeys.DFS_NAMENODE_MAX_DIRECTORY_ITEMS_KEY
            + " to a value less than 1 or greater than " + MAX_DIR_ITEMS);
{code}
We should update hdfs-default.xml also.

> Setting dfs.namenode.fs-limits.max-directory-items to 0 in hdfs-site.xml leads to error
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-7473
>                 URL: https://issues.apache.org/jira/browse/HDFS-7473
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.5.2
>            Reporter: Jason Keller
>
> When setting dfs.namenode.fs-limits.max-directory-items to 0 in hdfs-site.xml, the error
"java.lang.IllegalArgumentException: Cannot set dfs.namenode.fs-limits.max-directory-items
to a value less than 0 or greater than 6400000" is produced.  However, the documentation shows
that 0 is a valid setting for dfs.namenode.fs-limits.max-directory-items, turning the check
off.
> Looking into the code in hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
shows that the culprit is
> Preconditions.checkArgument(maxDirItems > 0 && maxDirItems <= MAX_DIR_ITEMS,
"Cannot set "+ DFSConfigKeys.DFS_NAMENODE_MAX_DIRECTORY_ITEMS_KEY+ " to a value less than
0 or greater than " + MAX_DIR_ITEMS);
> This checks if maxDirItems is greater than 0.  Since 0 is not greater than 0, it produces
an error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message