hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-7456) De-duplicate AclFeature instances with same AclEntries do reduce memory footprint of NameNode
Date Mon, 08 Dec 2014 07:16:12 GMT

     [ https://issues.apache.org/jira/browse/HDFS-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vinayakumar B updated HDFS-7456:
--------------------------------
    Attachment: HDFS-7456-003.patch

Thanks [~cnauroth] for the suggestions and comments.
Attaching the patch with {{ReferenceCountMap}} implementation. I chose this to avoid confusion
as there were multiple {{RefereceMap}} classes seen.

Instead of holding a separate {{Long}} as value, I found easy to give the original referenced
instance if that instance itself saved as value in map and it holds the reference count.

There was one more case where AclFeature reference count to be decreased. i.e. deletion of
nodes. That also I have covered. Tests also added for all above cases.

Let me know your feedback on this patch.

> De-duplicate AclFeature instances with same AclEntries do reduce memory footprint of
NameNode
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-7456
>                 URL: https://issues.apache.org/jira/browse/HDFS-7456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-7456-001.patch, HDFS-7456-002.patch, HDFS-7456-003.patch
>
>
> As discussed  in HDFS-7454 [here|https://issues.apache.org/jira/browse/HDFS-7454?focusedCommentId=14229454&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14229454],
de-duplication of {{AclFeature}} helps in reducing the memory footprint of the namenode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message