hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7056) Snapshot support for truncate
Date Tue, 23 Dec 2014 00:13:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256350#comment-14256350
] 

Konstantin Boudnik commented on HDFS-7056:
------------------------------------------

bq.  I would have if there were three or more values or a potential to have more. But its
exactly two. You are right we cannot change recoverLease() now. So it is better to have the
same pattern in truncate() to avoid even more confusion why this is done differently in two
cases.

I tend to agree with [~shv] here: a sudden introduction a new contract's fashion will be more
confusing. Besides, enforcing a enum for just two possible return values sounds excessive
and unnecessary. It'd be totally acceptable if the method could return say seven different
states.

bq. This actually raised a question for me how it will work with rolling upgrades. Thinking
about it.
Shall we address the rolling upgrade issue in a separate ticket? It seems that dragging this
much longer will have a significant impact on the patch maintenance: we already see multiple
iterations of the same patch just because of some minor changes in the trunk.

> Snapshot support for truncate
> -----------------------------
>
>                 Key: HDFS-7056
>                 URL: https://issues.apache.org/jira/browse/HDFS-7056
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Konstantin Shvachko
>            Assignee: Plamen Jeliazkov
>         Attachments: HDFS-3107-HDFS-7056-combined-13.patch, HDFS-3107-HDFS-7056-combined.patch,
HDFS-3107-HDFS-7056-combined.patch, HDFS-3107-HDFS-7056-combined.patch, HDFS-3107-HDFS-7056-combined.patch,
HDFS-3107-HDFS-7056-combined.patch, HDFS-3107-HDFS-7056-combined.patch, HDFS-3107-HDFS-7056-combined.patch,
HDFS-3107-HDFS-7056-combined.patch, HDFS-3107-HDFS-7056-combined.patch, HDFS-7056-13.patch,
HDFS-7056.patch, HDFS-7056.patch, HDFS-7056.patch, HDFS-7056.patch, HDFS-7056.patch, HDFS-7056.patch,
HDFS-7056.patch, HDFS-7056.patch, HDFSSnapshotWithTruncateDesign.docx
>
>
> Implementation of truncate in HDFS-3107 does not allow truncating files which are in
a snapshot. It is desirable to be able to truncate and still keep the old file state of the
file in the snapshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message