Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 4 Nov 2014 18:15:34 +0000 (UTC)
From: "Jing Zhao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12752605.1415065232000.411107.1415124934620@Atlassian.JIRA>
In-Reply-To: <JIRA.12752605.1415065232000@Atlassian.JIRA>
References: <JIRA.12752605.1415065232000@Atlassian.JIRA>
 <JIRA.12752605.1415065232264@arcas>
Subject: [jira] [Updated] (HDFS-7340) make rollingUpgrade start/finalize
 idempotent
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jing Zhao updated HDFS-7340:
----------------------------
    Attachment: HDFS-7340.001.patch

Thanks Suresh and Nicholas for the review. Update the patch to address Suresh's comments.

bq. add Idempotent annotation to the method

The ClientProtocol#rollingUpgrade has already been annotated as idempotent before the fix.

> make rollingUpgrade start/finalize idempotent
> ---------------------------------------------
>
>                 Key: HDFS-7340
>                 URL: https://issues.apache.org/jira/browse/HDFS-7340
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha
>    Affects Versions: 2.4.0
>            Reporter: Arpit Gupta
>            Assignee: Jing Zhao
>         Attachments: HDFS-7340.000.patch, HDFS-7340.001.patch
>
>
> I was running this on a HA cluster with dfs.client.test.drop.namenode.response.number set to 1. So the first request goes through but the response is dropped. Which then causes another request which fails and says a request is already in progress. We should add retry cache support for this.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)