Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0758217F32 for ; Tue, 4 Nov 2014 01:57:35 +0000 (UTC) Received: (qmail 72965 invoked by uid 500); 4 Nov 2014 01:57:34 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 72906 invoked by uid 500); 4 Nov 2014 01:57:34 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 72891 invoked by uid 99); 4 Nov 2014 01:57:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Nov 2014 01:57:34 +0000 Date: Tue, 4 Nov 2014 01:57:34 +0000 (UTC) From: "Yi Liu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7218) FSNamesystem ACL operations should write to audit log on failure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195560#comment-14195560 ] Yi Liu commented on HDFS-7218: ------------------------------ Thanks [~clamb], just one small nit, +1 after addressing. {code} logAuditEvent(success, "getAcl", src); {code} {{getAcl}} is better to be {{getAclStatus}} > FSNamesystem ACL operations should write to audit log on failure > ---------------------------------------------------------------- > > Key: HDFS-7218 > URL: https://issues.apache.org/jira/browse/HDFS-7218 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.6.0 > Reporter: Charles Lamb > Assignee: Charles Lamb > Priority: Minor > Attachments: HDFS-7218.001.patch, HDFS-7218.002.patch, HDFS-7218.003.patch, HDFS-7218.004.patch > > > Various Acl methods in FSNamesystem do not write to the audit log when the operation is not successful. -- This message was sent by Atlassian JIRA (v6.3.4#6332)