hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7403) Inaccurate javadoc of BlockUCState#COMPLETE state
Date Fri, 21 Nov 2014 11:36:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220797#comment-14220797
] 

Hadoop QA commented on HDFS-7403:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12682836/HDFS-7403.003.patch
  against trunk revision c298a9a.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8800//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8800//console

This message is automatically generated.

> Inaccurate javadoc of  BlockUCState#COMPLETE state
> --------------------------------------------------
>
>                 Key: HDFS-7403
>                 URL: https://issues.apache.org/jira/browse/HDFS-7403
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>         Attachments: HDFS-7403.001.patch, HDFS-7403.002.patch, HDFS-7403.003.patch
>
>
> The current javadoc says 
> {code}
>  /**
>    * States, which a block can go through while it is under construction.
>    */
>   static public enum BlockUCState {
>     /**
>      * Block construction completed.<br>
>      * The block has at least one {@link ReplicaState#FINALIZED} replica,
>      * and is not going to be modified.
>      */
>     COMPLETE,
> {code}
> However, COMPLETE blocks mean those that have reached minimal replication  "dfs.namenode.replication.min",
which could be different than one.
>  
> Creating this jira to fix the javadoc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message