hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7398) Reset cached thread-local FSEditLogOp's on every FSEditLog#logEdit
Date Mon, 17 Nov 2014 16:54:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214830#comment-14214830
] 

Chris Nauroth commented on HDFS-7398:
-------------------------------------

We could have {{FSEditLog#baseReset}} call the abstract {{reset}} after it resets {{txid}},
{{rpcClientId}} and {{rpcCallId}}.  That would still preserve the compile-time constraint
that new ops must implement {{reset}}.

If we do that, then we might also change up the naming a little bit, so that {{reset}} is
a final method called externally from {{FSEditLog}}, and we use {{doReset}} or {{resetSubfields}}
or some similar name for a protected abstract method.  That's just a nitpick though.

Thanks for putting this patch together, Gera!

> Reset cached thread-local FSEditLogOp's on every FSEditLog#logEdit
> ------------------------------------------------------------------
>
>                 Key: HDFS-7398
>                 URL: https://issues.apache.org/jira/browse/HDFS-7398
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.6.0
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: HDFS-7398.v01.patch
>
>
> This is a follow-up on HDFS-7385.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message