hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gera Shegalov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7398) Reset cached thread-local FSEditLogOp's on every FSEditLog#logEdit
Date Mon, 17 Nov 2014 16:44:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214820#comment-14214820
] 

Gera Shegalov commented on HDFS-7398:
-------------------------------------

Thanks for reviewing, Colin!

bq. But we can just have the derived class reset methods call baseReset, right? We shouldn't
need to call two functions to do the reset.

I should have written that I considered that as well. However, my main motivation was to make
it less likely that for a new op one forgets to call {{super#reset}}. That is why I chose
the current "design". What is your opinion looking from that angle?

> Reset cached thread-local FSEditLogOp's on every FSEditLog#logEdit
> ------------------------------------------------------------------
>
>                 Key: HDFS-7398
>                 URL: https://issues.apache.org/jira/browse/HDFS-7398
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.6.0
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: HDFS-7398.v01.patch
>
>
> This is a follow-up on HDFS-7385.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message