hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7358) Clients may get stuck waiting when using ByteArrayManager
Date Tue, 11 Nov 2014 00:43:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205685#comment-14205685
] 

Tsz Wo Nicholas Sze commented on HDFS-7358:
-------------------------------------------

> We need all this new synchronization on Packet? ...

TestHFlush calls write(..), interrupts the thread and then calls close().  Write(..) simply
puts data to the packet queue and DataStreamer, a separated thread, will get the packets from
the queue and then write it to socket.  Now, we set buf to null during close.  DataStreamer
may get NPE when accessing the data.  So the synchronization is required.

> nit: rename setClosed to close if you end up making a new patch.

We already has close(), which is the public user API for closing the stream.

> Clients may get stuck waiting when using ByteArrayManager
> ---------------------------------------------------------
>
>                 Key: HDFS-7358
>                 URL: https://issues.apache.org/jira/browse/HDFS-7358
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h7358_20141104.patch, h7358_20141104_wait_timeout.patch, h7358_20141105.patch,
h7358_20141106.patch, h7358_20141107.patch, h7358_20141108.patch
>
>
> [~stack] reported that clients might get stuck waiting when using ByteArrayManager; see
[his comments|https://issues.apache.org/jira/browse/HDFS-7276?focusedCommentId=14197036&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14197036].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message