hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7225) Remove stale block invalidation work when DN re-registers with different UUID
Date Wed, 19 Nov 2014 06:22:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217503#comment-14217503
] 

Hudson commented on HDFS-7225:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #6573 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6573/])
HDFS-7225. Remove stale block invalidation work when DN re-registers with different UUID.
(Zhe Zhang and Andrew Wang) (wang: rev 406c09ad1150c4971c2b7675fcb0263d40517fbf)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestComputeInvalidateWork.java


> Remove stale block invalidation work when DN re-registers with different UUID
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-7225
>                 URL: https://issues.apache.org/jira/browse/HDFS-7225
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.6.0
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>             Fix For: 2.7.0
>
>         Attachments: HDFS-7225-v1.patch, HDFS-7225-v2.patch, HDFS-7225-v3.patch, HDFS-7225.004.patch,
HDFS-7225.005.patch
>
>
> {{BlockManager#invalidateWorkForOneNode}} looks up a DataNode by the {{datanodeUuid}}
and passes the resultant {{DatanodeDescriptor}} to {{InvalidateBlocks#invalidateWork}}. However,
if a wrong or outdated {{datanodeUuid}} is used, a null pointer will be passed to {{invalidateWork}}
which will use it to lookup in a {{TreeMap}}. Since the key type is {{DatanodeDescriptor}},
key comparison is based on the IP address. A null key will crash the NameNode with an NPE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message