Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A2BC3176D3 for ; Mon, 6 Oct 2014 21:55:35 +0000 (UTC) Received: (qmail 6970 invoked by uid 500); 6 Oct 2014 21:55:34 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 6888 invoked by uid 500); 6 Oct 2014 21:55:34 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 6692 invoked by uid 99); 6 Oct 2014 21:55:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 21:55:34 +0000 Date: Mon, 6 Oct 2014 21:55:34 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7194) Fix findbugs "inefficient new String constructor" warning in DFSClient#PATH MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161043#comment-14161043 ] Hadoop QA commented on HDFS-7194: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12673186/HDFS-7194.002.patch against trunk revision 3affad9. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 12 warning messages. See https://builds.apache.org/job/PreCommit-HDFS-Build/8333//artifact/patchprocess/diffJavadocWarnings.txt for details. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The test build failed in hadoop-hdfs-project/hadoop-hdfs {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8333//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8333//console This message is automatically generated. > Fix findbugs "inefficient new String constructor" warning in DFSClient#PATH > --------------------------------------------------------------------------- > > Key: HDFS-7194 > URL: https://issues.apache.org/jira/browse/HDFS-7194 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Yongjun Zhang > Assignee: Yongjun Zhang > Priority: Trivial > Attachments: HDFS-7194.001.patch, HDFS-7194.002.patch > > > In recent PreCommit-HDFS-Build, 8325, 8324, 8323 etc, there is a findbugs warning: > {code} > Code Warning > Dm org.apache.hadoop.hdfs.DFSClient.() invokes inefficient new String(String) constructor > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)