hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7266) HDFS Peercache enabled check should not lock on object
Date Tue, 21 Oct 2014 15:12:37 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178495#comment-14178495
] 

Hudson commented on HDFS-7266:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1933 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1933/])
HDFS-7266. HDFS Peercache enabled check should not lock on object (awang via cmccabe) (cmccabe:
rev 4799570dfdb7987c2ac39716143341e9a3d9b7d2)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/PeerCache.java


> HDFS Peercache enabled check should not lock on object
> ------------------------------------------------------
>
>                 Key: HDFS-7266
>                 URL: https://issues.apache.org/jira/browse/HDFS-7266
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.7.0
>            Reporter: Gopal V
>            Assignee: Andrew Wang
>            Priority: Minor
>              Labels: multi-threading
>             Fix For: 2.7.0
>
>         Attachments: dfs-open-10-threads.png, hdfs-7266.001.patch
>
>
> HDFS fs.Open synchronizes on the Peercache, even when peer cache is disabled.
> {code}
>  public synchronized Peer get(DatanodeID dnId, boolean isDomain) {
>     if (capacity <= 0) { // disabled
>       return null;
>     }
> {code}
> since capacity is a final, this could be moved outside the lock.
> !dfs-open-10-threads.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message