hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7227) Fix findbugs warning about NP_DEREFERENCE_OF_READLINE_VALUE in SpanReceiverHost
Date Sun, 19 Oct 2014 11:32:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176280#comment-14176280
] 

Tsuyoshi OZAWA commented on HDFS-7227:
--------------------------------------

Hi [~cmccabe], [Java coding style|http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449]
says that we should avoid emitting braces:

{code}
The if-else class of statements should have the following form:

if (condition) {
    statements;
}

Note: if statements always use braces, {}. Avoid the following error-prone form:

if (condition) //AVOID! THIS OMITS THE BRACES {}!
    statement;
{code}


> Fix findbugs warning about NP_DEREFERENCE_OF_READLINE_VALUE in SpanReceiverHost
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-7227
>                 URL: https://issues.apache.org/jira/browse/HDFS-7227
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-7227.001.patch, HDFS-7227.002.patch
>
>
> Fix findbugs warning about NP_DEREFERENCE_OF_READLINE_VALUE in SpanReceiverHost



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message