hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Payne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7213) processIncrementalBlockReport performance degradation
Date Fri, 10 Oct 2014 13:38:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166837#comment-14166837

Eric Payne commented on HDFS-7213:

-1 tests included. The patch doesn't appear to include any new or modified tests.
 Please justify why no new tests are needed for this patch.
 Also please list what manual steps were performed to verify this patch.
Since the change is only adding an {{if debug}} around the log statement, unit testing would
be impractical.

-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
I believe that the failure of {{TestDNFencingWithReplication}} is an unrelated issue. Please
see HDFS-7221.

> processIncrementalBlockReport performance degradation
> -----------------------------------------------------
>                 Key: HDFS-7213
>                 URL: https://issues.apache.org/jira/browse/HDFS-7213
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.4.0
>            Reporter: Daryn Sharp
>            Assignee: Eric Payne
>            Priority: Critical
>         Attachments: HDFS-7213.1412804753, HDFS-7213.1412806496.txt
> {{BlockManager#processIncrementalBlockReport}} has a debug line that is missing a {{isDebugEnabled}}
check.  The write lock is being held.  Coupled with the increase in incremental block reports
from receiving blocks, under heavy load this log line noticeably degrades performance.

This message was sent by Atlassian JIRA

View raw message