hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7194) Two findbugs issues in recent PreCommit-HDFS-Build builds
Date Mon, 06 Oct 2014 20:49:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160918#comment-14160918
] 

Colin Patrick McCabe commented on HDFS-7194:
--------------------------------------------

bq. Could you check with Colin? I am not sure if he already has a plan fixing the findbugs
and javac warnings.

I think it's fine to fix the findbugs warning in this JIRA.

I am +1 on the patch pending jenkins.

> Two findbugs issues in recent PreCommit-HDFS-Build builds
> ---------------------------------------------------------
>
>                 Key: HDFS-7194
>                 URL: https://issues.apache.org/jira/browse/HDFS-7194
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>         Attachments: HDFS-7194.001.patch, HDFS-7194.002.patch
>
>
> In recent PreCommit-HDFS-Build, 8325, 8324, 8323 etc, there are findbugs warnings introduced
by earlier fixes.
> E.g.
> https://builds.apache.org/job/PreCommit-HDFS-Build/8324//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
> {quote}
> Bad practice Warnings
> Code	Warning
> Se	Class org.apache.hadoop.hdfs.protocol.datatransfer.ReplaceDatanodeOnFailure$Policy
defines non-transient non-serializable instance field condition
> Performance Warnings
> Code	Warning
> Dm	org.apache.hadoop.hdfs.DFSClient.<static initializer for DFSClient>() invokes
inefficient new String(String) constructor
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message