hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-7194) Two findbugs issues in recent PreCommit-HDFS-Build builds
Date Mon, 06 Oct 2014 18:51:34 GMT

     [ https://issues.apache.org/jira/browse/HDFS-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yongjun Zhang updated HDFS-7194:
--------------------------------
    Status: Patch Available  (was: Open)

Submitted patch 001. 

Hi [~szetszwo], the change I made for the first issue reported is in on top of HDFS-4257 code.
I see that currently we don't do serialization of ReplaceDatanodeOnFailure.Policy, so it should
be safe to change the "condition" filed to transient to remove the findbugs warnding. Would
you please comment in case I missed anything? thanks a lot.



> Two findbugs issues in recent PreCommit-HDFS-Build builds
> ---------------------------------------------------------
>
>                 Key: HDFS-7194
>                 URL: https://issues.apache.org/jira/browse/HDFS-7194
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>         Attachments: HDFS-7194.001.patch
>
>
> In recent PreCommit-HDFS-Build, 8325, 8324, 8323 etc, there are findbugs warnings introduced
by earlier fixes.
> E.g.
> https://builds.apache.org/job/PreCommit-HDFS-Build/8324//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
> {quote}
> Bad practice Warnings
> Code	Warning
> Se	Class org.apache.hadoop.hdfs.protocol.datatransfer.ReplaceDatanodeOnFailure$Policy
defines non-transient non-serializable instance field condition
> Performance Warnings
> Code	Warning
> Dm	org.apache.hadoop.hdfs.DFSClient.<static initializer for DFSClient>() invokes
inefficient new String(String) constructor
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message