hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-7190) Bad use of Preconditions in startFileInternal()
Date Fri, 03 Oct 2014 21:56:33 GMT
Konstantin Shvachko created HDFS-7190:
-----------------------------------------

             Summary: Bad use of Preconditions in startFileInternal()
                 Key: HDFS-7190
                 URL: https://issues.apache.org/jira/browse/HDFS-7190
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: namenode
    Affects Versions: 2.6.0
            Reporter: Konstantin Shvachko


The following precondition is in the middle of startFileInternal()
{code}
feInfo = new FileEncryptionInfo(suite, version,
        ....
Preconditions.checkNotNull(feInfo);
{code}
Preconditions are recommended to be used in the beginning of the method.
In this case the check is no-op anyways, because the variable has just been constructed.
Should be just removed.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message