hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7189) Add trace spans for DFSClient metadata operations
Date Sat, 04 Oct 2014 04:33:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158940#comment-14158940
] 

stack commented on HDFS-7189:
-----------------------------

This a bug fix?

1860	    TraceScope scope = Trace.startSpan("getStoragePolicies", traceSampler);
1861	    try {
1862	      return namenode.getStoragePolicies();
1863	    } catch (RemoteException e) {
1864	      throw e.unwrapRemoteException(AccessControlException.class,
1865	          FileNotFoundException.class,
1866	          SafeModeException.class,
1867	          NSQuotaExceededException.class,
1868	          UnresolvedPathException.class,
1869	          SnapshotAccessControlException.class);
1870	    } finally {

.. and in listCorruptFileBlocks etc. ?

Removing   checkOpen(); in delete is intentional ?

Is this intentional...  calling trace getCurrentEditLogTxid though its in getInotifyEventStream
... I suppose it is given it actually does do getCurrentEditLogTxid

public DFSInotifyEventInputStream getInotifyEventStream() throws IOException {	
3350	    long txid;
3351	    TraceScope scope = Trace.startSpan("getCurrentEditLogTxid", traceSampler);
3352	    try {
3353	      txid = namenode.getCurrentEditLogTxid();

Adding src/dst annotations is nice touch

Patch is great.

> Add trace spans for DFSClient metadata operations
> -------------------------------------------------
>
>                 Key: HDFS-7189
>                 URL: https://issues.apache.org/jira/browse/HDFS-7189
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 2.7.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7189.001.patch
>
>
> We should add trace spans for DFSClient metadata operations.  For example, {{DFSClient#rename}}
should have a trace span, etc. etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message