hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7090) Use unbuffered writes when persisting in-memory replicas
Date Fri, 10 Oct 2014 17:24:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167150#comment-14167150
] 

Xiaoyu Yao commented on HDFS-7090:
----------------------------------

Thanks Chris for the review. I will address them in the next patch. 


Good catch! I will fix it in the next patch.
Will remove the cross project javadoc links.
This is to create a local TEST_DIR declared in testCopyFileUnbuffered(), I change it to a
different name to avoid the confusion with the class member variable TEST_DIR. 

# Instead of catching exceptions and calling {{fail}}, we can just let the exception be thrown.
 We'll actually get more debugging information this way if a test fails, because JUnit will
print the full stack trace.
Good point. I will fix it in the next patch.

Fixed.

The link is broken but I will try to repro it on my machine.


-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.


> Use unbuffered writes when persisting in-memory replicas
> --------------------------------------------------------
>
>                 Key: HDFS-7090
>                 URL: https://issues.apache.org/jira/browse/HDFS-7090
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 2.6.0
>            Reporter: Arpit Agarwal
>            Assignee: Xiaoyu Yao
>             Fix For: 3.0.0
>
>         Attachments: HDFS-7090.0.patch, HDFS-7090.1.patch
>
>
> The LazyWriter thread just uses {{FileUtils.copyFile}} to copy block files to persistent
storage. It would be better to use unbuffered writes to avoid churning page cache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message