hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7055) Add tracing to DFSInputStream
Date Fri, 10 Oct 2014 20:48:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167484#comment-14167484

Tsz Wo Nicholas Sze commented on HDFS-7055:

bq. You guys know how this works. If Jenkins is green (or the red things in Jenkins can be
explained), then it is OK to commit. ...

There were indeed -1 javac and -1 findbugs from Jenkins for the patch committed here.  However,
the explanations given were quite sloppy.
- You said "The findbugs warnings are not related" but it turned out that one of the findbugs
warnings was related.
- You said "Meanwhile diffJavacWarnings.txt is missing, so I can't evaluate where there is
an additional warning or not."  But the diffJavacWarnings.txt was there for the later builds.
 Even if the file was missing, we could manually generate it.

bq. In this case, it seems that when I left a single slash out of the findbugs file caused
us to silently drop some findbugs reports for a while. That seems like a test-patch.sh bug
to me. The "friendly" thing to do would be to fix test-patch.sh to flag this condition so
that we didn't have to worry about this happening in the future.

There are many potential bugs that test-patch.sh is not able to catch.  Improving test-patch.sh
usually won't get into the priority.

bq. In the past I made a bunch of improvements to Jenkins. ...

Sure, I believe you did a lot of good work in the past.  Thank you!  I simply hope that you
could make sure the patches are all good before committing them.  Is it too much?

> Add tracing to DFSInputStream
> -----------------------------
>                 Key: HDFS-7055
>                 URL: https://issues.apache.org/jira/browse/HDFS-7055
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 2.6.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: 2.7.0
>         Attachments: HDFS-7055.002.patch, HDFS-7055.003.patch, HDFS-7055.004.patch, HDFS-7055.005.patch,
screenshot-get-1mb.005.png, screenshot-get-1mb.png
> Add tracing to DFSInputStream.

This message was sent by Atlassian JIRA

View raw message