hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7055) Add tracing to DFSInputStream
Date Fri, 10 Oct 2014 20:27:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167449#comment-14167449
] 

Colin Patrick McCabe commented on HDFS-7055:
--------------------------------------------

You guys know how this works.  If Jenkins is green (or the red things in Jenkins can be explained),
then it is OK to commit.  If it later turns out that Jenkins was not as thorough as it could
be, or had a bug, then that's a separate issue.

In this case, it seems that when I left a single slash out of the findbugs file caused us
to silently drop some findbugs reports for a while.  That seems like a test-patch.sh bug to
me.  The "friendly" thing to do would be to fix test-patch.sh to flag this condition so that
we didn't have to worry about this happening in the future.

In the past I made a bunch of improvements to Jenkins.  For example, in HADOOP-10325 I changed
it to using a diff-based system for javadoc warnings.  I reviewed HADOOP-9186 (which Binglin
posted) which gave us warnings when trunk compilation was broken.  It sounds like we need
another fix to make sure that we are actually getting the findbugs reports we need.

> Add tracing to DFSInputStream
> -----------------------------
>
>                 Key: HDFS-7055
>                 URL: https://issues.apache.org/jira/browse/HDFS-7055
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 2.6.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: 2.7.0
>
>         Attachments: HDFS-7055.002.patch, HDFS-7055.003.patch, HDFS-7055.004.patch, HDFS-7055.005.patch,
screenshot-get-1mb.005.png, screenshot-get-1mb.png
>
>
> Add tracing to DFSInputStream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message