Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9254317F82 for ; Thu, 25 Sep 2014 18:16:34 +0000 (UTC) Received: (qmail 78486 invoked by uid 500); 25 Sep 2014 18:16:34 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 78433 invoked by uid 500); 25 Sep 2014 18:16:34 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 78421 invoked by uid 99); 25 Sep 2014 18:16:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 18:16:34 +0000 Date: Thu, 25 Sep 2014 18:16:34 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HDFS-7144) Fix findbugs warnings in RamDiskReplicaTracker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal resolved HDFS-7144. --------------------------------- Resolution: Fixed Fix Version/s: HDFS-6581 Hadoop Flags: Reviewed +1 thanks a lot for helping out with this Nicholas! Committed to the feature branch. > Fix findbugs warnings in RamDiskReplicaTracker > ---------------------------------------------- > > Key: HDFS-7144 > URL: https://issues.apache.org/jira/browse/HDFS-7144 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Priority: Minor > Fix For: HDFS-6581 > > Attachments: h7144_20140925.patch > > > Two more findbugs warnings: > - Bad practice Warnings > org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.deleteSavedFiles() ignores exceptional return value of java.io.File.delete() > Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details) > In class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica > In method org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.deleteSavedFiles() > Called method java.io.File.delete() > At RamDiskReplicaTracker.java:[line 122] > Another occurrence at RamDiskReplicaTracker.java:[line 127] > - Dodgy Warnings > org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaLruTracker$RamDiskReplicaLru doesn't override RamDiskReplicaTracker$RamDiskReplica.equals(Object) > Bug type EQ_DOESNT_OVERRIDE_EQUALS (click for details) > In class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaLruTracker$RamDiskReplicaLru > Did you intend to override org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.equals(Object) > At RamDiskReplicaLruTracker.java:[lines 37-42] -- This message was sent by Atlassian JIRA (v6.3.4#6332)