Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 25 Sep 2014 19:52:34 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12743268.1411408445000.124645.1411674754477@Atlassian.JIRA>
In-Reply-To: <JIRA.12743268.1411408445000@Atlassian.JIRA>
References: <JIRA.12743268.1411408445000@Atlassian.JIRA>
 <JIRA.12743268.1411408445812@arcas>
Subject: [jira] [Commented] (HDFS-7119) Split error checks in
 AtomicFileOutputStream#close into separate conditions to improve
 diagnostics.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148219#comment-14148219 ] 

Hadoop QA commented on HDFS-7119:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12671254/HDFS-7119.1.patch
  against trunk revision 6c3cebd.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
                  org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8204//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8204//console

This message is automatically generated.

> Split error checks in AtomicFileOutputStream#close into separate conditions to improve diagnostics.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-7119
>                 URL: https://issues.apache.org/jira/browse/HDFS-7119
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: journal-node
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>         Attachments: HDFS-7119.1.patch
>
>
> {{AtomicFileOutputStream#close}} throws an exception if either deleting the original file or renaming the temp file fails, but the exception isn't specific about which step failed.  Splitting these into separate conditions with different error messages could help diagnose a permissions problem more quickly.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)