Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 30 Sep 2014 15:11:43 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12742853.1411163081000.155614.1412089903345@Atlassian.JIRA>
In-Reply-To: <JIRA.12742853.1411163081000@Atlassian.JIRA>
References: <JIRA.12742853.1411163081000@Atlassian.JIRA>
 <JIRA.12742853.1411163081380@arcas>
Subject: [jira] [Commented] (HDFS-7104) Fix and clarify INodeInPath getter
 functions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HDFS-7104?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14153=
261#comment-14153261 ]=20

Hudson commented on HDFS-7104:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1912 (See [https://builds.ap=
ache.org/job/Hadoop-Mapreduce-trunk/1912/])
HDFS-7104. Fix and clarify INodeInPath getter functions. Contributed by Zhe=
 Zhang. (wang: rev f0293f11a85176afc04d809574c9126a80b700cc)
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/serv=
er/namenode/TestSnapshotPathINodes.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/serv=
er/namenode/INodesInPath.java


> Fix and clarify INodeInPath getter functions
> --------------------------------------------
>
>                 Key: HDFS-7104
>                 URL: https://issues.apache.org/jira/browse/HDFS-7104
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>            Priority: Minor
>             Fix For: 2.6.0
>
>         Attachments: HDFS-7104-20140923-v1.patch, HDFS-7104-20140923-v3.p=
atch, HDFS-7104-20140924-v1.patch, HDFS-7104-20140924-v2.patch, HDFS-7104-2=
0140924-v3.patch
>
>
> inodes is initialized with the number of patch components. After resolve,=
 it contains both non-null and null elements (introduced by dot-snapshot di=
rs).
> When getINodes is called, an array is returned excluding all non elements=
, which is the correct behavior. Meanwhile, the inodes array is trimmed too=
, which shouldn't be done by a getter.
> Because of the above, the behavior of getINodesInPath depends on whether =
getINodes has been called, which is not correct.
> The name of getLastINodeInPath is confusing =E2=80=93 it actually returns=
 the last non-null inode in the path. Also, shouldn't the return type be a =
single INode?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)