Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C7871125E for ; Thu, 4 Sep 2014 02:55:52 +0000 (UTC) Received: (qmail 759 invoked by uid 500); 4 Sep 2014 02:55:51 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 708 invoked by uid 500); 4 Sep 2014 02:55:51 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 695 invoked by uid 99); 4 Sep 2014 02:55:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Sep 2014 02:55:51 +0000 Date: Thu, 4 Sep 2014 02:55:51 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-6981) DN upgrade with layout version change should not use trash MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6981?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDFS-6981: -------------------------------- Status: Patch Available (was: In Progress) > DN upgrade with layout version change should not use trash > ---------------------------------------------------------- > > Key: HDFS-6981 > URL: https://issues.apache.org/jira/browse/HDFS-6981 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 3.0.0 > Reporter: James Thomas > Assignee: Arpit Agarwal > Attachments: HDFS-6981.01.patch > > > Post HDFS-6800, we can encounter the following scenario: > # We start with DN software version -55 and initiate a rolling upgrade to= version -56 > # We delete some blocks, and they are moved to trash > # We roll back to DN software version -55 using the -rollback flag =E2=80= =93 since we are running the old code (prior to this patch), we will restor= e the previous directory but will not delete the trash > # We append to some of the blocks that were deleted in step 2 > # We then restart a DN that contains blocks that were appended to =E2=80= =93 since the trash still exists, it will be restored at this point, the ap= pended-to blocks will be overwritten, and we will lose the appended data > So I think we need to avoid writing anything to the trash directory if we= have a previous directory. > Thanks to [~james.thomas] for reporting this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)