Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 10 Sep 2014 20:27:34 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12401609.1217863918000.2783.1410380854305@Atlassian.JIRA>
In-Reply-To: <JIRA.12401609.1217863918000@Atlassian.JIRA>
References: <JIRA.12401609.1217863918000@Atlassian.JIRA>
 <JIRA.12401609.1217863918428@arcas>
Subject: [jira] [Commented] (HDFS-49) MiniDFSCluster.stopDataNode will
 always shut down a node in the cluster if a matching name is not found
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129037#comment-14129037 ] 

Hadoop QA commented on HDFS-49:
-------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12667794/HDFS-49-002.patch
  against trunk revision b67d5ba.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
                  org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7985//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7985//console

This message is automatically generated.

> MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-49
>                 URL: https://issues.apache.org/jira/browse/HDFS-49
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.1.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>              Labels: codereview, newbie
>         Attachments: HDFS-49-002.patch, hdfs-49.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The stopDataNode method will shut down the last node in the list of nodes, if one matching a specific name is not found
> This is possibly not what was intended. Better to return false or fail in some other manner if the named node was not located
>  synchronized boolean stopDataNode(String name) {
>     int i;
>     for (i = 0; i < dataNodes.size(); i++) {
>       DataNode dn = dataNodes.get(i).datanode;
>       if (dn.dnRegistration.getName().equals(name)) {
>         break;
>       }
>     }
>     return stopDataNode(i);
>   }


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)