Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA35F11A9C for ; Wed, 10 Sep 2014 17:47:34 +0000 (UTC) Received: (qmail 98071 invoked by uid 500); 10 Sep 2014 17:47:34 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 98018 invoked by uid 500); 10 Sep 2014 17:47:34 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 98005 invoked by uid 99); 10 Sep 2014 17:47:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Sep 2014 17:47:34 +0000 Date: Wed, 10 Sep 2014 17:47:34 +0000 (UTC) From: "Steve Loughran (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-49) MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HDFS-49: ------------------------------- Attachment: HDFS-49-002.patch patch 002, applies to trunk > MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found > ------------------------------------------------------------------------------------------------------- > > Key: HDFS-49 > URL: https://issues.apache.org/jira/browse/HDFS-49 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.20.204.0, 0.20.205.0, 1.1.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Minor > Labels: codereview, newbie > Attachments: HDFS-49-002.patch, hdfs-49.patch > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > The stopDataNode method will shut down the last node in the list of nodes, if one matching a specific name is not found > This is possibly not what was intended. Better to return false or fail in some other manner if the named node was not located > synchronized boolean stopDataNode(String name) { > int i; > for (i = 0; i < dataNodes.size(); i++) { > DataNode dn = dataNodes.get(i).datanode; > if (dn.dnRegistration.getName().equals(name)) { > break; > } > } > return stopDataNode(i); > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)